Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 72.46% 75.76% +3.30%
==========================================
Files 9 9
Lines 345 392 +47
Branches 60 73 +13
==========================================
+ Hits 250 297 +47
Misses 61 61
Partials 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cottsay
force-pushed
the
cottsay/versions
branch
from
331a024 to
78a39b3
Compare
cottsay
force-pushed
the
cottsay/versions
branch
2 times, most recently
from
2a183a1 to
608c8a5
Compare
This change brings support for reading the version constraints from the dependencies specified in Cargo.toml manifests. It supports the full range of version syntax accepted by cargo. The behavior enabled by this change aligns colcon-cargo with other build system extensions, and will notify the user with a warning during a build where an incompatible version of a package is present in a workspace which has one or more other packages requiring a different version of it.
cottsay
force-pushed
the
cottsay/versions
branch
from
608c8a5 to
307bb25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change brings support for reading the version constraints from the dependencies specified in
Cargo.tomlmanifests. It supports the full range of syntax with the exception of complex wildcards such as1.*.3.The behavior enabled by this change aligns
colcon-cargowith other build system extensions, and will notify the user with a warning during a build where an incompatible version of a package is present in a workspace which has one or more other packages requiring a different version of it.Example message:
colcon.colcon_core.package_augmentation.check_dependency_constraint WARNING cargo-package-a depends on cargo-package-b which has version 1.1.0 but expects it to be greater than or equal to 1.3.0https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#version-requirement-syntax